[#STS-404] friendly url and ";jsessionid=...." - Stripes

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: Release 1.5
Fix Version/s: Release 1.5.1, Release 1.6
Component/s: ActionBean Dispatching
Labels:
None
Environment:
linux jetty

Description

i tried the clean/friendly url from stripes' trunk code. everything seems nice except when the user uses the application for the first time, when jsessionid is appended to the end of the link, it seems to cause some issues. further look at it seems like any link with extra ";something" in the end has trouble..

Issue Links

Dependency

This issue Is depended on by:
~~STS-581~~ Clean URLs and URL Rewriting issues in Jetty 6.1.3. Session String is parsed as internal variable.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Ray Tsang added a comment - 02/Aug/07 8:43 AM

by trouble i mean it would include the ";....." values as part of the parsed values and include it in the variable..

e.g... /a/myaction/{id}
/a/my/action/1234 <- works fine, id = 1234
/a/my/action/1234;jsessionid=..... <- fails, id = 1234;jsessiond=.... ?

i haven't double checked but it seems like it's behaving this way

Show

Ray Tsang added a comment - 02/Aug/07 8:43 AM by trouble i mean it would include the ";....." values as part of the parsed values and include it in the variable.. e.g... /a/myaction/{id} /a/my/action/1234 <- works fine, id = 1234 /a/my/action/1234;jsessionid=..... <- fails, id = 1234;jsessiond=.... ? i haven't double checked but it seems like it's behaving this way

Hide

Permalink

Ben Gunter added a comment - 11/Jan/08 11:48 PM

It is the responsibility of the app server to ensure that such session IDs don't mess with the code running in the server. If this is happening in Jetty then I believe it's a Jetty bug, not a Stripes bug. I just tested it under Tomcat, and it worked just fine. I'm closing this as not a bug.

Show

Ben Gunter added a comment - 11/Jan/08 11:48 PM It is the responsibility of the app server to ensure that such session IDs don't mess with the code running in the server. If this is happening in Jetty then I believe it's a Jetty bug, not a Stripes bug. I just tested it under Tomcat, and it worked just fine. I'm closing this as not a bug.

Hide

Permalink

Iwao AVE! added a comment - 19/Feb/08 10:42 AM

I was going to file it on jetty's jira, but the issue has already been discussed several times on their list.
And Greg Wilkins (the lead of jetty project) had concluded that the current behavior is consistent with the servlet spec.

http://thread.gmane.org/gmane.comp.java.jetty.support/2614/focus=2708
http://thread.gmane.org/gmane.comp.java.jetty.support/6819/focus=6824

Although the servlet spec should be written clearer, SRV.4.1 seems to suggest Greg's view.
What do you think?

Show

Iwao AVE! added a comment - 19/Feb/08 10:42 AM I was going to file it on jetty's jira, but the issue has already been discussed several times on their list. And Greg Wilkins (the lead of jetty project) had concluded that the current behavior is consistent with the servlet spec. http://thread.gmane.org/gmane.comp.java.jetty.support/2614/focus=2708 http://thread.gmane.org/gmane.comp.java.jetty.support/6819/focus=6824 Although the servlet spec should be written clearer, SRV.4.1 seems to suggest Greg's view. What do you think?

Hide

Permalink

Ben Gunter added a comment - 22/Oct/08 10:27 AM

I'm only reopening this so I can resolve it as fixed.

Show

Ben Gunter added a comment - 22/Oct/08 10:27 AM I'm only reopening this so I can resolve it as fixed.

Hide

Permalink

Ben Gunter added a comment - 22/Oct/08 10:28 AM

As noted in ~~STS-581~~, this was fixed with ~~STS-575~~.

Show

Ben Gunter added a comment - 22/Oct/08 10:28 AM As noted in ~~STS-581~~, this was fixed with ~~STS-575~~.

People

Assignee:

Ben Gunter

Reporter:

Ray Tsang

Vote (0)

Watch (0)

Dates

Created:

02/Aug/07 8:41 AM

Updated:

04/Jan/11 2:48 PM

Resolved:

22/Oct/08 10:28 AM