[#STS-435] Change clean URLs not to rely on internal forwards - Stripes

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: Release 1.5
Component/s: ActionBean Dispatching
Labels:
None

Description

The clean URL code currently relies on internal forwards to expose parameters embedded in the URI. I'm no longer comfortable with this approach as it has proven to be problematic. The code should instead use a request wrapper to expose the parameters.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Ben Gunter added a comment - 15/Nov/07 10:08 PM

Internal forwards are no longer used. Instead, when necessary, StripesRequestWrapper copies the original parameter maps and merges the URI-embedded parameters into it.

Show

Ben Gunter added a comment - 15/Nov/07 10:08 PM Internal forwards are no longer used. Instead, when necessary, StripesRequestWrapper copies the original parameter maps and merges the URI-embedded parameters into it.

Hide

Permalink

Ben Gunter added a comment - 16/Nov/07 10:38 AM

When a request is forwarded, any parameters present in the new request URL are not visible. The new parameters are added to the original parameter map. Since StripesRequestWrapper creates its own parameter map, the new parameters are hidden.

Show

Ben Gunter added a comment - 16/Nov/07 10:38 AM When a request is forwarded, any parameters present in the new request URL are not visible. The new parameters are added to the original parameter map. Since StripesRequestWrapper creates its own parameter map, the new parameters are hidden.

Hide

Permalink

Ben Gunter added a comment - 16/Nov/07 9:52 PM

Changed so that, when appropriate, getParameterMap() returns a Map implementation that merges the parameter values on the fly.

Show

Ben Gunter added a comment - 16/Nov/07 9:52 PM Changed so that, when appropriate, getParameterMap() returns a Map implementation that merges the parameter values on the fly.

Hide

Permalink

Ben Gunter added a comment - 03/Dec/07 9:04 PM

The fix for ~~STS-448~~ breaks URI parameters on internal forwards. The strategy should be changed so that it does not require multiple request wrappers.

Show

Ben Gunter added a comment - 03/Dec/07 9:04 PM The fix for ~~STS-448~~ breaks URI parameters on internal forwards. The strategy should be changed so that it does not require multiple request wrappers.

Hide

Permalink

Ben Gunter added a comment - 04/Dec/07 8:31 AM

The fix for ~~STS-448~~ broke clean URLs on internal forwards because the code depended on layers of StripesRequestWrappers. That is no longer the case. When a request is forwarded through StripesFilter, the filter notifies the lone StripesRequestWrapper, which merges any new URI parameters into the ones from the previous request.

Show

Ben Gunter added a comment - 04/Dec/07 8:31 AM The fix for ~~STS-448~~ broke clean URLs on internal forwards because the code depended on layers of StripesRequestWrappers. That is no longer the case. When a request is forwarded through StripesFilter, the filter notifies the lone StripesRequestWrapper, which merges any new URI parameters into the ones from the previous request.

People

Assignee:

Ben Gunter

Reporter:

Ben Gunter

Vote (0)

Watch (0)

Dates

Created:

15/Nov/07 8:51 PM

Updated:

04/Jan/11 3:10 PM

Resolved:

04/Dec/07 8:31 AM