Stripes

Avoid session creation in MessagesTag#getMessages

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: Release 1.5
  • Fix Version/s: Release 1.5
  • Component/s: Tag Library
  • Labels:
    None

Description

MessagesTag#getMessages() tries to look up the list of messages in the session if none are found in the request. This lookup should only occur if there is a session present!

if (messages == null) { messages = (List<Message>) request.getSession().getAttribute( getKey() ); request.getSession().removeAttribute( getKey() ); }

should become

if (messages == null && request.getSession(false) != null) {
...

(change on line 151 in current Stripes 1.5b1)

Activity

Hide
Ben Gunter added a comment - 06/Feb/08 7:32 AM

Fixed for 1.5.

Show
Ben Gunter added a comment - 06/Feb/08 7:32 AM Fixed for 1.5.

People

Vote (0)
Watch (0)

Dates

  • Created:
    06/Feb/08 7:11 AM
    Updated:
    04/Jan/11 2:49 PM
    Resolved:
    06/Feb/08 7:32 AM