Stripes

Hidden _sourcePage value incorrect for included pages

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: Release 1.5, Release 1.5.1
  • Fix Version/s: Release 1.5.1, Release 1.5.2
  • Component/s: Tag Library
  • Labels:
    None

Description

When a page is included via <jsp:include> or some other means, the _sourcePage input points to the page from which it was included instead of to the included resource itself.

Activity

Hide
Ben Gunter added a comment - 03/Apr/09 11:04 AM

This has been troublesome for a few people. It appears that the problem that this fixed can be worked around by using <c:import> instead of <jsp:include>. If that is the case, then this change needs to be reverted for 1.5.2.

Show
Ben Gunter added a comment - 03/Apr/09 11:04 AM This has been troublesome for a few people. It appears that the problem that this fixed can be worked around by using <c:import> instead of <jsp:include>. If that is the case, then this change needs to be reverted for 1.5.2.
Hide
Ben Gunter added a comment - 26/May/09 10:23 AM

Based on my testing, <c:import> behaves no differently from <jsp:include>, but I have discovered other, more serious issues with the behavior introduced with this change. The <s:layout-render> tag can sometimes throw a NPE when there are validation errors; reverting this change fixed the NPE. I see plenty of reason to revert to the former behavior so I've done that for 1.5.2.

Show
Ben Gunter added a comment - 26/May/09 10:23 AM Based on my testing, <c:import> behaves no differently from <jsp:include>, but I have discovered other, more serious issues with the behavior introduced with this change. The <s:layout-render> tag can sometimes throw a NPE when there are validation errors; reverting this change fixed the NPE. I see plenty of reason to revert to the former behavior so I've done that for 1.5.2.

People

Vote (3)
Watch (4)

Dates

  • Created:
    05/Jan/09 10:40 PM
    Updated:
    04/Jan/11 1:58 PM
    Resolved:
    26/May/09 10:23 AM