[#STS-643] FormTag wizardFields doesn't clean the stack correctl.y - Stripes

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: Release 1.5
Fix Version/s: Release 1.5.1, Release 1.6
Component/s: Tag Library
Labels:
None

Description

When using @Wizard the FormTag is not popping all items off the stripes tag stack correctly. It ends up leaving the enclosing form on the stack, which in certain cases leads to unusual behavior. Such as a label outside of any form tag finding the form on the stack and complaining about properties being null.

Seems to be a fairly simple fix, and I've attached a patch. This seems to have appeard between 1.5rc1 and 1.5 as we were using 1.5rc1 for a while and never noticed this.

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

patch.txt

29/Jan/09 8:20 AM

0.4 kB

Nick Stuart

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Nick Stuart added a comment - 29/Jan/09 8:20 AM

patch to call wizardTag.doFinally()

Show

Nick Stuart added a comment - 29/Jan/09 8:20 AM patch to call wizardTag.doFinally()

Hide

Permalink

Frederic Daoud added a comment - 09/Feb/09 9:36 PM

Fixed in build 1039 (trunk) and 1040 (1.5.x). I put the call to doFinally in a finally { } block.

Show

Frederic Daoud added a comment - 09/Feb/09 9:36 PM Fixed in build 1039 (trunk) and 1040 (1.5.x). I put the call to doFinally in a finally { } block.

People

Assignee:

Frederic Daoud

Reporter:

Nick Stuart

Vote (0)

Watch (0)

Dates

Created:

29/Jan/09 8:19 AM

Updated:

04/Jan/11 1:59 PM

Resolved:

09/Feb/09 9:36 PM