[#STS-653] Eliminate UrlBindingFactory.getInstance() - Stripes

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: Release 1.5
Fix Version/s: Release 1.6
Component/s: ActionBean Dispatching
Labels:
None

Description

UrlBindingFactory has a public static getInstance() method to get a reference to a singleton instance. This should be eliminated. Instead, the ActionResolver should create its own private instance.

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

FileBasedActionResolver.java

16/May/09 9:28 AM

3 kB

Andrew Jaquith

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Ben Gunter added a comment - 28/Feb/09 4:47 PM

AnnotatedClassActionResolver now creates its own private UrlBindingFactory instance. Other classes that were using UrlBindingFactory.getInstance() now get it from the ActionResolver. If the ActionResolver they get from Configuration is not a subclass of AnnotatedClassActionResolver, then they do not attempt to use UrlBindingFactory at all.

Show

Ben Gunter added a comment - 28/Feb/09 4:47 PM AnnotatedClassActionResolver now creates its own private UrlBindingFactory instance. Other classes that were using UrlBindingFactory.getInstance() now get it from the ActionResolver. If the ActionResolver they get from Configuration is not a subclass of AnnotatedClassActionResolver, then they do not attempt to use UrlBindingFactory at all.

Hide

Permalink

Ben Gunter added a comment - 02/Mar/09 7:17 PM

We've decided that 1.5.1 will be bug fixes only so I'm removing this from 1.5.1. The commits that have been made for this issue to the 1.5.x branch will be rolled back. Look for this enhancement in 1.6.

Show

Ben Gunter added a comment - 02/Mar/09 7:17 PM We've decided that 1.5.1 will be bug fixes only so I'm removing this from 1.5.1. The commits that have been made for this issue to the 1.5.x branch will be rolled back. Look for this enhancement in 1.6.

Hide

Permalink

Andrew Jaquith added a comment - 16/May/09 9:28 AM

Ben: I've been watching the changes in SVN for this. I have a keen interest in understanding how this will work. For example, see the attached FileBasedActionResolver, which externalizes the UrlBinding definitions. It's rough and unpolished, but you get the idea.

It looks like UrlBindingFactory.getInstance() could simply be changed to AnnotatedClassActionResolver.getUrlBindingFactory() in 1.6.

Show

Andrew Jaquith added a comment - 16/May/09 9:28 AM Ben: I've been watching the changes in SVN for this. I have a keen interest in understanding how this will work. For example, see the attached FileBasedActionResolver, which externalizes the UrlBinding definitions. It's rough and unpolished, but you get the idea. It looks like UrlBindingFactory.getInstance() could simply be changed to AnnotatedClassActionResolver.getUrlBindingFactory() in 1.6.

People

Assignee:

Ben Gunter

Reporter:

Ben Gunter

Vote (0)

Watch (0)

Dates

Created:

28/Feb/09 4:00 PM

Updated:

04/Jan/11 2:38 PM

Resolved:

28/Feb/09 4:47 PM