Stripes

Annotated class action resolver - add action bean - loop at the bottom is just for log.debug but is not surrouned with isDebugEnabled

Details

Description

Hi,

This snippet here, line 146 .. this runs all the way through and is effectively a noop and wasted cycles if debug is not on. That whole block should be surround with is debug enabled, but the log class doesn't have such a method.

// Print out the event mappings nicely
for (Map.Entry<String, Method> entry : classMappings.entrySet()) { String event = entry.getKey(); Method handler = entry.getValue(); boolean isDefault = DEFAULT_HANDLER_KEY.equals(event); log.debug("Bound: ", clazz.getSimpleName(), ".", handler.getName(), "() ==> ", binding, isDefault ? "" : "?" + event); }

Activity

Hide
Frederic Daoud added a comment - 16/Sep/09 4:21 PM

Fixed in revision 1144.

Show
Frederic Daoud added a comment - 16/Sep/09 4:21 PM Fixed in revision 1144.

People

Vote (0)
Watch (0)

Dates

  • Created:
    08/Apr/09 9:56 AM
    Updated:
    04/Jan/11 1:56 PM
    Resolved:
    27/Oct/09 2:27 PM