[#STS-683] Ability to disable localized lookup of label attribute for options-collection (and possibly other) tags - Stripes

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: Release 1.5.1
Fix Version/s: Release 1.6
Component/s: Tag Library
Labels:
None

Description

Hello,

The options collection tag tries to localize ALL labels in the collection. There should be an attribute, localizeLabels=true (default?) to skip over this block.

For some reason this is just on by default even though I bet most stripes apps are either not localized, or are but done in their own different way. Particularly with regards to select labels, those often come from the database and not a property file. I can see how this may be useful, just questioning whether it really is that often or should be the default. I think if you knew you wanted localized labels, you would go and look for this feature to turn on instead of just trying it and being nicely surprised.

2 unnecessary bundle lookups for every <option tag (there are thousands!) on this page should not be happening unless told to do so by the page author. thoughts?

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Frederic Daoud added a comment - 07/Jun/10 2:12 PM

I agree. There should be a way to turn off bundle lookups if they are unnecessary. I'll look into this.

Show

Frederic Daoud added a comment - 07/Jun/10 2:12 PM I agree. There should be a way to turn off bundle lookups if they are unnecessary. I'll look into this.

Hide

Permalink

John Newman added a comment - 07/Jun/10 2:22 PM

Just looking at this one again months after I freaked out about it, I think it would be best to leave the default as is to avoid surprising someone who has been using it all along. I hate sacrificing anything for backwards compatibility, but it is better safe than sorry.

Then, you just need a rather prominent note in the doco: "If you don't care about localization, or dont want stripes to care about your locailizaiton, set <this> to true to disable the tag bundle lookups and increase performance. This is done by default for backwards compatibility" maybe? idk

Show

John Newman added a comment - 07/Jun/10 2:22 PM Just looking at this one again months after I freaked out about it, I think it would be best to leave the default as is to avoid surprising someone who has been using it all along. I hate sacrificing anything for backwards compatibility, but it is better safe than sorry. Then, you just need a rather prominent note in the doco: "If you don't care about localization, or dont want stripes to care about your locailizaiton, set <this> to true to disable the tag bundle lookups and increase performance. This is done by default for backwards compatibility" maybe? idk

Hide

Permalink

Frederic Daoud added a comment - 08/Jun/10 7:18 AM

Yes, I just tried adding a localizeLabels attribute, true by default, which you can use to turn off localization attempts. Seems to work fine. I need to do a few more tests and refine the documentation, then I'll check it in.

Show

Frederic Daoud added a comment - 08/Jun/10 7:18 AM Yes, I just tried adding a localizeLabels attribute, true by default, which you can use to turn off localization attempts. Seems to work fine. I need to do a few more tests and refine the documentation, then I'll check it in.

Hide

Permalink

Frederic Daoud added a comment - 08/Jun/10 3:37 PM

Fixed in build 1254.

Show

Frederic Daoud added a comment - 08/Jun/10 3:37 PM Fixed in build 1254.

People

Assignee:

Frederic Daoud

Reporter:

John Newman

Vote (0)

Watch (0)

Dates

Created:

06/May/09 3:13 PM

Updated:

04/Jan/11 3:12 PM

Resolved:

08/Jun/10 3:37 PM