[#STS-719] Partial forms do not work within layout components - Stripes

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: Release 1.5.1
Fix Version/s: Release 1.5.4
Component/s: Tag Library
Labels:
None

Description

When a layout definition contains a form tag and a layout component contains a partial form tag, things go awry. Layout components are evaluated before the layout definition. At the time the inner, partial form tag is evaluated, the outer form tag does not yet exist. This breaks several things including form repopulation and automatic setting of the form's enctype for file uploads.

Issue Links

Dependency

This issue Depends on:
~~STS-674~~ Partial form cause File Tag to fail
~~STS-709~~ Stripes Wizard misses tags included in nested <stripes:form partial="true"> tags
~~STS-391~~ Layout tags don't handle huge inserted contents (layout definitions) well, usage results in OutOfMemory errors

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Ben Gunter added a comment - 16/Oct/09 1:15 PM

~~STS-674~~ is a bug report about a symptom of the larger issue with partial forms and layouts.

Show

Ben Gunter added a comment - 16/Oct/09 1:15 PM ~~STS-674~~ is a bug report about a symptom of the larger issue with partial forms and layouts.

Hide

Permalink

Ben Gunter added a comment - 16/Oct/09 1:18 PM

~~STS-709~~ is a bug report about a symptom of the larger issue with layouts and partial forms.

Show

Ben Gunter added a comment - 16/Oct/09 1:18 PM ~~STS-709~~ is a bug report about a symptom of the larger issue with layouts and partial forms.

Hide

Permalink

Ben Gunter added a comment - 18/May/10 2:51 PM

I'm doing some testing now, and it appears that the changes that allow layout tags to stream output instead of buffering it also fix the issues with layouts and forms. Changing the layout tags to stream output also changed it to execute the components in the order they appear in the layout definition and execute them during execution of the layout definition itself.

We're still testing ~~STS-391~~. Once it is resolved, this issue and all others related to it likely will be resolved as well.

Show

Ben Gunter added a comment - 18/May/10 2:51 PM I'm doing some testing now, and it appears that the changes that allow layout tags to stream output instead of buffering it also fix the issues with layouts and forms. Changing the layout tags to stream output also changed it to execute the components in the order they appear in the layout definition and execute them during execution of the layout definition itself. We're still testing ~~STS-391~~. Once it is resolved, this issue and all others related to it likely will be resolved as well.

People

Assignee:

Unassigned

Reporter:

Ben Gunter

Vote (1)

Watch (1)

Dates

Created:

16/Oct/09 1:14 PM

Updated:

04/Jan/11 1:26 PM

Resolved:

30/Sep/10 10:05 AM