Stripes

UrlBindingFactory interprets parameters first in url as conflict

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Cannot Reproduce
  • Affects Version/s: Release 1.5.1, Release 1.5.2
  • Fix Version/s: None
  • Component/s: ActionBean Dispatching
  • Labels:
    None

Description

I would like to have a parameter first in my urls, representing different sections of a site; eg: @UrlBinding("/{section}/foo/bar/{$event}.html")
This UrlBinding results in a conflict between all ActionBeans using the {section} parameter. While debugging I find the UrlBindingFactory.getBindingPrototype(String uri) method ignoring the componentMatch when checking if we have a conflict, which seems to be a bug. At least in this case the result is not logical.

Additionally when I use the url "/section1/foo/bar.html", the section parameter is set to "section1/foo/bar".
This works and gives me the default handler if I dont have the section as a parameter. Perhaps these two issues are related?

Activity

Hide
Kris Luhr added a comment - 12/Nov/09 7:00 AM

Proposed patch for the conflict issue.

When removing the last slash I my tests pass the default handler issue, but the issue remains when I deploy the application. Is there another place with the same logic parsing urls somewhere?

Show
Kris Luhr added a comment - 12/Nov/09 7:00 AM Proposed patch for the conflict issue. When removing the last slash I my tests pass the default handler issue, but the issue remains when I deploy the application. Is there another place with the same logic parsing urls somewhere?
Hide
Ben Gunter added a comment - 16/Dec/09 9:39 AM

Please submit some concrete examples so that I can really understand what binding you are using, what you expect to happen and what actually is happening. Thanks.

Show
Ben Gunter added a comment - 16/Dec/09 9:39 AM Please submit some concrete examples so that I can really understand what binding you are using, what you expect to happen and what actually is happening. Thanks.
Hide
Ben Gunter added a comment - 18/May/10 2:24 PM

I've tried to reproduce this, as I understand it, against the 1.5.x branch. Everything seems to be working fine, and I haven't received a response since I asked for more information months ago. Closing as Cannot Reproduce.

Show
Ben Gunter added a comment - 18/May/10 2:24 PM I've tried to reproduce this, as I understand it, against the 1.5.x branch. Everything seems to be working fine, and I haven't received a response since I asked for more information months ago. Closing as Cannot Reproduce.

People

Vote (0)
Watch (1)

Dates

  • Created:
    12/Nov/09 6:55 AM
    Updated:
    04/Jan/11 1:31 PM
    Resolved:
    18/May/10 2:24 PM