[#STS-762] Eliminate UrlBindingFactory.getInstance() from 1.5.x branch - Stripes

Details

Type: Improvement
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: Release 1.5.3
Fix Version/s: Release 1.5.4
Component/s: ActionBean Dispatching
Labels:
None

Description

We are using stripes in an OSGi platform environment where we have multiple web applications using the same instance of stripes. The UrlBindingFactory singleton makes it impossible for any of our web applications to use the same url binding, i.e. a commonly used binding like "/Home.action" or "/Login.action" cannot be used by two different web applications.

This appears to have already been fixed in trunk and according to the comments on ~~STS-653~~ was at one point fixed in the 1.5.x branch. It seems straight-forward to backport this change once again to the 1.5.x branch which would be greatly beneficial to us.

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

David Maplesden added a comment - 25/Aug/10 5:25 PM

To clarify exactly what we are asking for here: all we want is for the change in revision 1074 of trunk to be merged into the 1.5.x branch.

I have tested this merge on a local copy of the 1.5.x branch and it works perfectly with no conflicts. I have also built and tested stripes 1.5.x after the merge and it seems to work perfectly, it certainly allows us to do what we want.

Show

David Maplesden added a comment - 25/Aug/10 5:25 PM To clarify exactly what we are asking for here: all we want is for the change in revision 1074 of trunk to be merged into the 1.5.x branch. I have tested this merge on a local copy of the 1.5.x branch and it works perfectly with no conflicts. I have also built and tested stripes 1.5.x after the merge and it seems to work perfectly, it certainly allows us to do what we want.

Hide

Permalink

David Maplesden added a comment - 21/Sep/10 8:41 PM

Please, is there someone available to comment on the status of this ticket.

This is a critical issue for us and we need to know when it might be available in a released version of Stripes. We would very much like it to be fixed in the next 1.5.x branch release but could probably live with using 1.6 if it were to be available soon.

Merging the change from revision 1074 of trunk to the 1.5.x branch literally took me 2 minutes to complete, this is not a hard fix to backport.

Thanks

Show

David Maplesden added a comment - 21/Sep/10 8:41 PM Please, is there someone available to comment on the status of this ticket. This is a critical issue for us and we need to know when it might be available in a released version of Stripes. We would very much like it to be fixed in the next 1.5.x branch release but could probably live with using 1.6 if it were to be available soon. Merging the change from revision 1074 of trunk to the 1.5.x branch literally took me 2 minutes to complete, this is not a hard fix to backport. Thanks

Hide

Permalink

Ben Gunter added a comment - 22/Sep/10 11:01 AM

I was planning on waiting until 1.6, but if you really need this I can do it for 1.5.4. I cannot, however, give an estimate at this time as to when 1.5.4 will be released.

Show

Ben Gunter added a comment - 22/Sep/10 11:01 AM I was planning on waiting until 1.6, but if you really need this I can do it for 1.5.4. I cannot, however, give an estimate at this time as to when 1.5.4 will be released.

Hide

Permalink

David Maplesden added a comment - 22/Sep/10 2:54 PM

Fantastic, that would be much appreciated.

Of course an estimated release date for 1.5.4 would be useful for us. If there is anything I can do to help then let me know. I am an experienced Java developer working at a commercial development company that uses Stripes, so we would be open to helping where required to get a release out. I have a little open source experience, I had commit rights for JBoss for a couple of years and made significant contributions to their JMS implementation when we were actively using their software (some years ago now).

Show

David Maplesden added a comment - 22/Sep/10 2:54 PM Fantastic, that would be much appreciated. Of course an estimated release date for 1.5.4 would be useful for us. If there is anything I can do to help then let me know. I am an experienced Java developer working at a commercial development company that uses Stripes, so we would be open to helping where required to get a release out. I have a little open source experience, I had commit rights for JBoss for a couple of years and made significant contributions to their JMS implementation when we were actively using their software (some years ago now).

Hide

Permalink

Ben Gunter added a comment - 24/Sep/10 1:47 PM

There are just a few things left to be done for 1.5.4, and they all fall on me because they involve code I either wrote or recently hacked to pieces. I think five of the open issues for 1.5.4 are basically all just one thing that I'm either going to implement correctly or roll back so we can get the release out. Remi Vankiesbelck got things working yesterday with Maven and central sync, which had been a big problem for me in working toward 1.5.4.

Thanks very much for the offer of help. I'll keep you in mind in the future.

Show

Ben Gunter added a comment - 24/Sep/10 1:47 PM There are just a few things left to be done for 1.5.4, and they all fall on me because they involve code I either wrote or recently hacked to pieces. I think five of the open issues for 1.5.4 are basically all just one thing that I'm either going to implement correctly or roll back so we can get the release out. Remi Vankiesbelck got things working yesterday with Maven and central sync, which had been a big problem for me in working toward 1.5.4. Thanks very much for the offer of help. I'll keep you in mind in the future.

Hide

Permalink

David Gleeson added a comment - 08/Nov/10 7:03 PM

Would you please reconsider a timely release of 1.5.4 without the currently unresolved fix for ~~STS-678~~ ? As a software house with waiting customers our options are to wait for infinity or to package stripes ourselves.

Show

David Gleeson added a comment - 08/Nov/10 7:03 PM Would you please reconsider a timely release of 1.5.4 without the currently unresolved fix for ~~STS-678~~ ? As a software house with waiting customers our options are to wait for infinity or to package stripes ourselves.

People

Assignee:

Ben Gunter

Reporter:

David Maplesden

Vote (0)

Watch (1)

Dates

Created:

25/Aug/10 4:05 PM

Updated:

04/Jan/11 1:04 PM

Resolved:

24/Sep/10 1:27 PM